Skip to content

Commit

Permalink
Set npm version for frontend-maven-plugin
Browse files Browse the repository at this point in the history
When using NodeJS 4+, the frontend-maven-plugin uses the bundled npm,
but it ends up not being available via PATH lookup. That causes issue
when one package.json has a script that invokes npm (it can not be
found).

Set <npmVersion> to the version being used on Wikimedia CI which would
hopefully install npm in a directory belonging to PATH.

eirslett/frontend-maven-plugin#560
https://github.com/eirslett/frontend-maven-plugin#installing-node-and-npm

Bug: T188285
Change-Id: Ia892dcfdc1c0ef055f00a493941e974198323012
  • Loading branch information
hashar committed Feb 26, 2018
1 parent 7992506 commit 5b2ac64
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions pom.xml
Expand Up @@ -758,6 +758,15 @@
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<version>1.6</version>
<configuration>
<!--
npm installed from NodeJS distribution turns out
to not be in PATH which has side effects.
https://phabricator.wikimedia.org/T188285
https://github.com/eirslett/frontend-maven-plugin/issues/560
-->
<npmVersion>3.8.3</npmVersion>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down

0 comments on commit 5b2ac64

Please sign in to comment.