Add outline: 0 to flagged property/value combinations

[Volker-E]

outline: 0 is seen an accessibility anti-pattern and there are several places, where this was introduced for styling reasons and assumed lack of knowledge.
I'd propose for adding it to 'declaration-property-value-blacklist' which would need an extra override in case you're re-adding custom focus styles to your project.

[Volker-E]

@edg2s @Krinkle @jdlrobson @j4n-co your thoughts…?

[Volker-E]

Example I came from here: https://github.com/wikimedia/mediawiki-skins-MinervaNeue/blob/master/resources/skins.minerva.base.styles/ui.less#L148

[edg2s]

Seems reasonable. Are there any other examples in MW core, VE etc?

[Volker-E]

Oh yeah:
https://codesearch.wmflabs.org/search/?q=outline%3A%200&i=nope&files=&repos=

• lib/jquery.chosen
• ContentTranslation
  • cardSearch
  • search tool
• DonationInterface
• Flow menu

and so forth and so on…

[edg2s]

As discussed, let's add a custom warning message for disabled properties that links to a wiki page (on wiki or github) outlining the reasoning for each disabled property.

[Volker-E]

@edg2s It would look like this

"declaration-property-value-blacklist": [ {
			"outline": ["/none/", "/0/"]
		},
			"message": "No `outline` is an accessibility anti-pattern. Only use when focussed state is ensured." ]

Not sure how to deal with two different blacklist items though…

Update: Doesnt' seem to work for one rule:
stylelint/stylelint#551 (comment)

[Volker-E]

@edg2s Let's move this forward, I'd suggest leaving a comment in the index.js instead. We've got a number of opinionated rules in here. And it's fair to expect certain engagement from devs with rules from a linter in our environment.
We've also been so far bringing the changes to the single repos, so that devs have an anchor point for orientation.