Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give an rationale for why we enforce certain property values, using message property. #30

Open
Volker-E opened this issue Jul 15, 2016 · 3 comments

Comments

@Volker-E
Copy link
Contributor

Volker-E commented Jul 15, 2016

Should we provide comments in index.js on certain property values? The "stylelint-value-border-zero" plugin returned

Line 292, column 3: 'border: 0' is preferred over 'border: none' (value-border-zero) (error)

while declaration-property-value-blacklist offers following error

292:3 ✖ Unexpected value "none" for property "border" declaration-property-value-blacklist

It could be a bit more insightful. The blacklist rule doesn't provide option to customize output. So I think providing guidance in comments/links to guiding principles would be useful…

@edg2s
Copy link
Member

edg2s commented Jul 15, 2016

The json format doesn't support comments which would make this harder to do.

@Volker-E
Copy link
Contributor Author

The file features .js extension so far (actually wanted to write index.js in the issue title), so it would be more easily possible as long as we stick with JS.

@Volker-E Volker-E changed the title Provide explanatory comment in index.json for enforcing certain property values Provide explanatory comment in index.js for enforcing certain property values Jul 17, 2016
@jdforrester jdforrester changed the title Provide explanatory comment in index.js for enforcing certain property values Consider giving an explanatory rationale in index.js for why we enforce certain property values Jul 20, 2016
@Volker-E
Copy link
Contributor Author

See also #89 (comment). message would provide fine-tailored feedback to devs.

@edg2s edg2s changed the title Consider giving an explanatory rationale in index.js for why we enforce certain property values Give an rationale for why we enforce certain property values, using message property. May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants