Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop git in gemspec #745

Merged
merged 1 commit into from Sep 25, 2020
Merged

Drop git in gemspec #745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Expand Up @@ -7,7 +7,7 @@ Gemfile.lock
InstalledFiles
_yardoc
coverage
lib/bundler/man
lib/bundler/man/*
pkg
rdoc
yardoc
Expand Down
21 changes: 1 addition & 20 deletions parser.gemspec
View file
Open in desktop
Expand Up @@ -20,27 +20,8 @@ Gem::Specification.new do |spec|
'source_code_uri' => "https://github.com/whitequark/parser/tree/v#{spec.version}"
}

spec.files = `git ls-files`.split + %w(
lib/parser/lexer.rb
lib/parser/ruby18.rb
lib/parser/ruby19.rb
lib/parser/ruby20.rb
lib/parser/ruby21.rb
lib/parser/ruby22.rb
lib/parser/ruby23.rb
lib/parser/ruby24.rb
lib/parser/ruby25.rb
lib/parser/ruby26.rb
lib/parser/ruby27.rb
lib/parser/ruby30.rb
lib/parser/macruby.rb
lib/parser/rubymotion.rb
) - %w(
.gitignore
)

spec.files = Dir['bin/*', 'lib/**/*.rb', 'parser.gemspec']
Copy link
Collaborator

@mbj mbj Oct 2, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, and this is not a bad thing: before parser would ship anything which was not gitignored explicit (or in the whitelist) this means that the parser gem will not ship tests anymore. Which is IMO a good thing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, happy to have it this way!

spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
spec.test_files = spec.files.grep(%r{^test/})
spec.require_paths = ['lib']

spec.required_ruby_version = '>= 2.0.0'
Expand Down