Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iliabylich OT: But thought triggered by your commit, I think parser should not use
git
at all to find packaged files.See: mbj/mutant#1052 where I improved the packagability for debian and others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait, is there a debian package of
parser
? This field is used to build.gem
file locally and push it to rubygems.org. I agree that it requiresgit
locally to build it (which is kinda bad if you only to build a package), but at the same time it offers freedom of using any test files that are added to global.gitignore
(I have files liketest<1-10>.rb
there).I'd prefer to keep it as is if nobody needs it. Feel free to send a PR that fixes it though, I'll merge it (and I'll do cleanup of my local garbage 😄 ), but if it's just a "good practice" that nobody needs I'd like to ignore it 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@utkarsh2102 feel free to weigh in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eee, hello 👋🏻
I am the maintainer of
parser
in Debian. It's actively maintained and is synced with the latest version! 😄(so first of all, thanks for your work, really! 💯)
Yep, thanks @mbj for pointing this out, using
git
is a bit troublesome and it's best if avoided!The complete rationale is here: https://docs.rubocop.org/rubocop-packaging/cops_packaging.html#gemspec-git-rationale
I'll be v happy to send a PR to drop
git
from gemspec! 🌮There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please. I think
{bin,lib}/**/*.rb
pattern should be enoughThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will also drop the
.y
which are not needed for a bundled gem. Should be a nice size reduction.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, great! Will open a PR later today; completing my school homework for now! 😭