Use AST::Processor::Mixin instead of deprecated AST::Processor
#1000
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR uses `AST::Processor::Mixin` instead of deprecated `AST::Processor` API:
```ruby
# This class includes {AST::Processor::Mixin}; however, it is
# deprecated, since the module defines all of the behaviors that
# the processor includes. Any new libraries should use
# {AST::Processor::Mixin} instead of subclassing this.
#
# @deprecated Use {AST::Processor::Mixin} instead.
```
https://github.com/whitequark/ast/blob/v2.4.2/lib/ast/processor.rb#L2-L7
There is an imcompatibility where the inheritance no longer includes `AST::Processor`,
but the impact is expected to be negligible.
koic
force-pushed
the
use_ast_processor_mixin
branch
from
d8fd9f7
to
93add41
Compare
|
Makes sense, thanks! |
stanhu
added a commit
to stanhu/inspec
that referenced
this pull request
Apr 26, 2024
parser 3.3.1.0 introduced whitequark/parser#1000, which causes this failure: ``` % bundle exec ruby -Itest test/unit/profiles/profile_test.rb inspec/lib/inspec/utils/profile_ast_helpers.rb:7:in `<class:CollectorBase>': uninitialized constant Parser::AST::Processor::Mixin (NameError) include Parser::AST::Processor::Mixin ^^^^^^^ ``` Fix this by inherting from `Parser::AST::Processor` and requiring the right version of the `parser` gem. Closes inspec#7029
4 tasks
stanhu
added a commit
to stanhu/inspec
that referenced
this pull request
Apr 26, 2024
parser 3.3.1.0 introduced whitequark/parser#1000, which causes this failure: ``` % bundle exec ruby -Itest test/unit/profiles/profile_test.rb inspec/lib/inspec/utils/profile_ast_helpers.rb:7:in `<class:CollectorBase>': uninitialized constant Parser::AST::Processor::Mixin (NameError) include Parser::AST::Processor::Mixin ^^^^^^^ ``` Fix this by inherting from `Parser::AST::Processor` and requiring the right version of the `parser` gem. Closes inspec#7029 Signed-off-by: Stan Hu <stanhu@gmail.com>
stanhu
added a commit
to stanhu/inspec
that referenced
this pull request
Apr 30, 2024
parser 3.3.1.0 introduced whitequark/parser#1000, which causes this failure: ``` % bundle exec ruby -Itest test/unit/profiles/profile_test.rb inspec/lib/inspec/utils/profile_ast_helpers.rb:7:in `<class:CollectorBase>': uninitialized constant Parser::AST::Processor::Mixin (NameError) include Parser::AST::Processor::Mixin ^^^^^^^ ``` Fix this by inherting from `Parser::AST::Processor` instead. Closes inspec#7029 Signed-off-by: Stan Hu <stanhu@gmail.com>
stanhu
added a commit
to stanhu/inspec
that referenced
this pull request
Apr 30, 2024
parser 3.3.1.0 introduced whitequark/parser#1000, which causes this failure: ``` % bundle exec ruby -Itest test/unit/profiles/profile_test.rb inspec/lib/inspec/utils/profile_ast_helpers.rb:7:in `<class:CollectorBase>': uninitialized constant Parser::AST::Processor::Mixin (NameError) include Parser::AST::Processor::Mixin ^^^^^^^ ``` Fix this by inherting from `Parser::AST::Processor` instead. Closes inspec#7029 Signed-off-by: Stan Hu <stanhu@gmail.com>
ahasunos
pushed a commit
to inspec/inspec
that referenced
this pull request
May 2, 2024
parser 3.3.1.0 introduced whitequark/parser#1000, which causes this failure: ``` % bundle exec ruby -Itest test/unit/profiles/profile_test.rb inspec/lib/inspec/utils/profile_ast_helpers.rb:7:in `<class:CollectorBase>': uninitialized constant Parser::AST::Processor::Mixin (NameError) include Parser::AST::Processor::Mixin ^^^^^^^ ``` Fix this by inherting from `Parser::AST::Processor` instead. Closes #7029 Signed-off-by: Stan Hu <stanhu@gmail.com>
ahasunos
pushed a commit
to inspec/inspec
that referenced
this pull request
May 2, 2024
parser 3.3.1.0 introduced whitequark/parser#1000, which causes this failure: ``` % bundle exec ruby -Itest test/unit/profiles/profile_test.rb inspec/lib/inspec/utils/profile_ast_helpers.rb:7:in `<class:CollectorBase>': uninitialized constant Parser::AST::Processor::Mixin (NameError) include Parser::AST::Processor::Mixin ^^^^^^^ ``` Fix this by inherting from `Parser::AST::Processor` instead. Closes #7029 Signed-off-by: Stan Hu <stanhu@gmail.com>
ahasunos
added a commit
to inspec/inspec
that referenced
this pull request
May 2, 2024
parser 3.3.1.0 introduced whitequark/parser#1000, which causes this failure: ``` % bundle exec ruby -Itest test/unit/profiles/profile_test.rb inspec/lib/inspec/utils/profile_ast_helpers.rb:7:in `<class:CollectorBase>': uninitialized constant Parser::AST::Processor::Mixin (NameError) include Parser::AST::Processor::Mixin ^^^^^^^ ``` Fix this by inherting from `Parser::AST::Processor` instead. Closes #7029 Signed-off-by: Stan Hu <stanhu@gmail.com> Co-authored-by: Stan Hu <stanhu@gmail.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses
AST::Processor::Mixininstead of deprecatedAST::ProcessorAPI:https://github.com/whitequark/ast/blob/v2.4.2/lib/ast/processor.rb#L2-L7
There is an imcompatibility where the inheritance no longer includes
AST::Processor, but the impact is expected to be negligible.