Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bytes 1.0 and prost 0.7, actix next, Tokio 1.0 #55

Merged
merged 6 commits into from Jan 24, 2021
Merged

Bytes 1.0 and prost 0.7, actix next, Tokio 1.0 #55

merged 6 commits into from Jan 24, 2021

Conversation

rubdos
Copy link
Member

@rubdos rubdos commented Dec 29, 2020

Bytes 1.0 is out (hooray), and prost just updated to it too. We're still waiting for actix to get there, and they'll probably do that together with Tokio 1.0. Large dependency push, so I am doing it in a separate draft pr.

Wait for:

@gferon
Copy link
Collaborator

gferon commented Jan 8, 2021

@rubdos I checked actix-web because they just merged their MR, or would you like to wait for the crate to be released to crates.io?

@rubdos
Copy link
Member Author

rubdos commented Jan 8, 2021

@rubdos I checked actix-web because they just merged their MR, or would you like to wait for the crate to be released to crates.io?

They pushed a beta yesterday, I've upgraded to that in this MR.

What's up with warp? EDIT: lol

futures::select! {
_ = ka_interval.next() => {
_ = tick => {
Copy link
Member Author

@rubdos rubdos Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gferon What do you think about this? tokio-rs/tokio@7f17822 adds a stream implementation again, but this may be cleaner...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, this is what's supposed to land as std::future::Stream rather sooner than later, so it's not part of tokio 1.0, or did I misunderstand what you meant?

@gferon
Copy link
Collaborator

gferon commented Jan 24, 2021

mpart-async 0.5 was published after merging cetra3/mpart-async#17, so I think you can finish this one 😄

EDIT: sorry, I was trigger happy, I fixed the last 2 tiny things to be able to ship this!

@gferon gferon marked this pull request as ready for review January 24, 2021 12:13
@rubdos rubdos merged commit cd4719c into master Jan 24, 2021
@rubdos
Copy link
Member Author

rubdos commented Jan 24, 2021

Very much 🥳 to this :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants