New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bytes 1.0 and prost 0.7, actix next, Tokio 1.0 #55
Conversation
@rubdos I checked |
They pushed a beta yesterday, I've upgraded to that in this MR. What's up with |
futures::select! { | ||
_ = ka_interval.next() => { | ||
_ = tick => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gferon What do you think about this? tokio-rs/tokio@7f17822 adds a stream implementation again, but this may be cleaner...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, this is what's supposed to land as std::future::Stream
rather sooner than later, so it's not part of tokio 1.0, or did I misunderstand what you meant?
EDIT: sorry, I was trigger happy, I fixed the last 2 tiny things to be able to ship this! |
Very much 🥳 to this :-) |
Bytes 1.0 is out (hooray), and prost just updated to it too. We're still waiting for actix to get there, and they'll probably do that together with Tokio 1.0. Large dependency push, so I am doing it in a separate draft pr.
Wait for: