Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Groups #297

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Fix Groups #297

merged 1 commit into from
Mar 18, 2024

Conversation

Schmiddiii
Copy link
Contributor

Fixes #296.

@gferon
Copy link
Collaborator

gferon commented Mar 18, 2024

Great find!

@gferon gferon merged commit c072491 into whisperfish:main Mar 18, 2024
15 of 18 checks passed
@Schmiddiii Schmiddiii deleted the fix-groups branch March 18, 2024 11:43
@Schmiddiii Schmiddiii mentioned this pull request Mar 18, 2024
Merged
@rubdos
Copy link
Member

rubdos commented Mar 18, 2024

Sounds like we should also expose the false-equivalent.

@Schmiddiii
Copy link
Contributor Author

Both in recent versions of Signal-Desktop and Signal-Android, this value is hardcoded to true. So not sure we should expose a false-equivalent.

@rubdos
Copy link
Member

rubdos commented Mar 18, 2024

Both in recent versions of Signal-Desktop and Signal-Android, this value is hardcoded to true. So not sure we should expose a false-equivalent.

Awesome, thanks for sharing that. Not even the /v1/certificate/auth/group?redemptionStartSeconds={}&redemptionEndSeconds={} without the additional pniAsServiceId?

@rubdos
Copy link
Member

rubdos commented Mar 18, 2024

Awesome, thanks for sharing that. Not even the /v1/certificate/auth/group?redemptionStartSeconds={}&redemptionEndSeconds={} without the additional pniAsServiceId?

Nope! So we don't have to expose it for now. Cool.

@gferon gferon mentioned this pull request Mar 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Groups Fail with Newly Linked Devices
3 participants
@Schmiddiii @gferon @rubdos