Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always fire CloseWatcher/dialog cancel events #10291

Merged
merged 1 commit into from
May 10, 2024
Merged

Always fire CloseWatcher/dialog cancel events #10291

merged 1 commit into from
May 10, 2024

Commits on Apr 22, 2024

  1. Always fire CloseWatcher/dialog cancel events 

    Previously, the anti-abuse mechanisms would sometimes skip these events. However, as discussed in #10047, it is more useful to fire them, and have the anti-abuse mechanisms set cancelable to false for them when appropriate. This allows observing close requests vs. other types of closes, by looking for the cancel event.

Closes #10047.
    @domenic
    domenic committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    9eec117 View commit details
    Browse the repository at this point in the history