Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close dialog elements when the open attribute is removed #10124

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Close dialog elements when the open attribute is removed #10124

wants to merge 6 commits into from

Commits on Feb 5, 2024

  1. Close dialog elements when the open attribute is removed 

    Fixes whatwg#5802

This patch adds attribute change steps to run the dialog closing steps
whenever the open attribute is removed in order to prevent a bad state
where the dialog is hidden but modal which renders the rest of the page
inert.
    @josepharhar
    josepharhar committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    128a87e View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. add ignoreOpenAttribute parameter

    @josepharhar
    josepharhar committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    9cdcfdd View commit details
    Browse the repository at this point in the history

  2. delete notes

    @josepharhar
    josepharhar committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    ae5c95d View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2024

  1. fix closing tag

    @josepharhar
    josepharhar committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    6f65d03 View commit details
    Browse the repository at this point in the history

  2. split into two algorithms

    @josepharhar
    josepharhar committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    d84add3 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2024

  1. remove ignoreopenattribute

    @josepharhar
    josepharhar committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    42df787 View commit details
    Browse the repository at this point in the history