-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4532: language sensitivity of autocap #10119
Open
aphillips
wants to merge
3
commits into
whatwg:main
Choose a base branch
from
aphillips:aphillips-autocap-4532
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"titlecase letter" needs a reference. Assuming this is about the Unicode code point category.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't necessarily about the code point category. Titlecasing is more complicated than just the explicit mappings, since some languages use digraphs and titlecase them in different ways (compare Serbian
dz
and Dutchij
). Anyway, happy to add a reference. Where should it point? Unicode glossary?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a reasonable reference, but it needs to be introduced above as part of the Unicode and Encoding section. It seems we currently don't reference any terms from Unicode, but you can use introductory wording similar to what we do for Encoding. Let me know if you need help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Part of me is twitching because we generally use the i18n-glossary as a proxy for Unicode terminology. We don't have
titlecase
defined there either, at the moment, but could do, especially as we have extensive illustrations of the problems being discussed here in charmod-norm.In the interim 52d6dd8 includes a link to the Unicode glossary. I will look at the Unicode and Encoding section in HTML and make an additional push after that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i18n-glossary has reached production (TR) with 'titlecase' exported.
I looked at the "Unicode and Encoding" section, but that seems to be where terms exported from Encoding are brought in. Encoding has no reason to define upper/lower/titlecase, so I feel like this doesn't belong there.
I see that there is a section about Infra (and a list of imported terms) there (and this list naturally includes the ASCII casing terms (
ASCII lowercase
,ASCII uppercase
,ASCII case-insensitive
) that are core to HTML. Unicode case handling isn't there either, but could be incorporated.Given that this is a "fleeting reference", can we keep it local? Failing that, we could link the I18N glossary or we could link Character Model: String Matching which explains case folding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also where in theory we could bring in references from Unicode (it's both Encoding and Unicode after all). Would need an equivalent paragraph and list.
I'm not entirely sure how I feel about referencing the i18n glossary or the Character Model as those documents feel like they're summarizing more authoritative sources and I'd rather we reference the latter.