Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support setting websocket credential mode #1273

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support setting websocket credential mode #1273

wants to merge 2 commits into from

Conversation

lucacasonato
Copy link
Member

@lucacasonato lucacasonato commented Jul 23, 2021 •
edited by pr-preview bot

Accompanying change for whatwg/html#6896

Preview | Diff

annevk
annevk reviewed Jul 26, 2021
View reviewed changes
fetch.bs Outdated Show resolved Hide resolved
annevk
annevk reviewed Jul 26, 2021
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed a nit, but looks good to me apart from that. I guess the main thing here is getting implementer interest and tests, probably best managed as part of the HTML change.

fetch.bs
@@ -7533,7 +7533,7 @@ therefore not shareable, a WebSocket connection is very close to identical to an
<h3 id=websocket-opening-handshake>Opening handshake</h3>

<p>To <dfn id=concept-websocket-establish>establish a WebSocket connection</dfn>, given a
<var>url</var>, <var>protocols</var>, and <var>client</var>, run these steps:
<var>url</var>, <var>protocols</var>, <var>credentialsMode</var>, and <var>client</var>, run these steps:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: exceeds a 100 columns.

@annevk annevk added addition/proposal New features or enhancements needs implementer interest Moving the issue forward requires implementers to express interest do not merge yet Pull request must not be merged per rationale in comment labels Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk left review comments

Assignees
No one assigned
Labels
addition/proposal New features or enhancements do not merge yet Pull request must not be merged per rationale in comment needs implementer interest Moving the issue forward requires implementers to express interest
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lucacasonato @annevk