Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support streaming rendering #27

Merged
merged 18 commits into from
Jan 3, 2022
Merged

Conversation

wfxr
Copy link
Owner

@wfxr wfxr commented Jan 3, 2022

Check list

  • I have read through the README (especially F.A.Q section)
  • I have searched through the existing issues or pull requests
  • I have performed a self-review of my code and commented hard-to-understand areas
  • I have made corresponding changes to the documentation (when necessary)

Description

The crate prettytable-rs which csview depends on does not support streaming rendering, which may cause oom when using csview to view very large csv files. Considering the crate hasn't been maintained for a long time I decide to implement a table render in csview to support streaming rendering.

#19

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Breaking change
  • Documentation change
  • CICD related improvement

Test environment

  • OS
    • Linux
    • Mac OS X
    • Windows
    • Others:

@wfxr wfxr changed the title WIP feat: implement table writer feat: support streaming rendering Jan 3, 2022
@wfxr wfxr merged commit 90ff90e into master Jan 3, 2022
@wfxr wfxr deleted the feature/support-streaming-rendering branch January 3, 2022 13:28
@wfxr wfxr mentioned this pull request Jan 3, 2022
6 tasks
@wfxr wfxr restored the feature/support-streaming-rendering branch July 2, 2022 07:48
@wfxr wfxr deleted the feature/support-streaming-rendering branch July 2, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant