Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underline type nodes without position mappings in .types baselines #69

Conversation

weswigham
Copy link
Owner

Makes type baselines read like

var a14: (x: { a: string; b: number }) => Object;
>a14 : (x: { a: string; b: number; }) => Object
>    : ^^^^                         ^^^^^^^^^^^

Where the underlines point out characters in spans without explicit positional mappings.

@weswigham
Copy link
Owner Author

d249531 Has an example of what diffs to these will look like on the web UI - broad improvements do tend to affect a large number of baselines, but that's only because we have a lot of low-hanging fruit in terms of actually copying position information onto output nodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant