Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MacOS Tests to GH Actions #335

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

jeremyleung521
Copy link
Member

@jeremyleung521 jeremyleung521 commented Aug 3, 2023

Issue Number. Is this pull request related to any outstanding issues? If so, list the issue number.
#251 #325

Describe the changes made. A clear and concise description of what the problem is and what you did to fix it. E.g. [...] was happening and I've changed [...] to fix it.
With #251 fixing things, I think we should start running tests on MacOS to make sure everything works. It will take a little longer, but at < 15 minutes, it is fine!
(Example of a working workflow: https://github.com/westpa/westpa/actions/runs/5754524605)

Also forgot to update the test_env.yaml with pytest-rerunfailures and remove nose in #325!

Goals and Outstanding Issues. A clear and concise list of goals (to be) accomplished.

  • More comprehensive testing!

Major files changed.

  • .github/workflows/test.yaml
  • devtools/conda-envs/test_env.yaml

Status.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Additional context. Add any other context or screenshots about the pull request here.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #335 (02cefc6) into develop (e022c31) will increase coverage by 0.04%.
Report is 1 commits behind head on develop.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #335      +/-   ##
===========================================
+ Coverage    41.35%   41.39%   +0.04%     
===========================================
  Files          131      131              
  Lines        16967    16967              
===========================================
+ Hits          7016     7024       +8     
+ Misses        9951     9943       -8     
Flag Coverage Δ
unittests 41.39% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@jeremyleung521 jeremyleung521 marked this pull request as draft August 3, 2023 19:37
@jeremyleung521 jeremyleung521 marked this pull request as ready for review August 3, 2023 19:37
@jeremyleung521 jeremyleung521 reopened this Aug 3, 2023
@jeremyleung521 jeremyleung521 merged commit 5fd4bd0 into westpa:develop Aug 3, 2023
28 checks passed
@jeremyleung521 jeremyleung521 deleted the github_mac_test branch August 9, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants