updating based on comments on the PR

Signed-off-by: westford14 <westford14@gmail.com>
westford14 · Nov 2, 2021 · e7591e1 · e7591e1
1 parent 25d3f88
commit e7591e1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/mlflow/tracking/_tracking_service/client.py b/mlflow/tracking/_tracking_service/client.py
@@ -251,11 +251,11 @@ def set_tag(self, run_id, key, value):
         :param run_id: String ID of the run.
         :param key: Tag name (string). This string may only contain alphanumerics, underscores 
                     (_), dashes (-), periods (.), spaces ( ), and slashes (/).
-                    All backend stores will support keys up to length 250 but some may 
-                    support larger key values.
+                    All backend stores will support keys up to length 250, but some may 
+                    support larger keys.
         :param value: Tag value (string, but will be string-ified if not).
-                      All backend stores will support values up to length 5000 but some 
-                      may support larger key values.
+                      All backend stores will support values up to length 5000, but some 
+                      may support larger values.
         """
         _validate_tag_name(key)
         tag = RunTag(key, str(value))

diff --git a/mlflow/tracking/client.py b/mlflow/tracking/client.py
@@ -638,9 +638,13 @@ def log_metric(
         :param run_id: The run id to which the metric should be logged.
         :param key: Metric name (string). This string may only contain alphanumerics, underscores 
                     (_), dashes (-), periods (.), spaces ( ), and slashes (/).
+                    All backend stores will support keys up to length 250, but some may 
+                    support larger keys.
         :param value: Metric value (float). Note that some special values such
                       as +/- Infinity may be replaced by other values depending on the store. For
                       example, the SQLAlchemy store replaces +/- Inf with max / min float values.
+                      All backend stores will support values up to length 5000, but some 
+                      may support larger values.
         :param timestamp: Time when this metric was calculated. Defaults to the current system time.
         :param step: Integer training step (iteration) at which was the metric calculated.
                      Defaults to 0.