fix: Babel transpiler fixes #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 29, 2023
simonihmig
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Left one comment, otherwise this looks good to me! (but I have no authority here 🙃)
This would also fix #215, which I just ran into...
|
@wessberg could you please look into this? The issues getting solved by this (three of them!) would become significant blockers for continuing to use this plugin for "us" (Ember.js ecosystem). Thank you! 🙏 |
wessberg
requested changes
Aug 3, 2023
|
LGTM. Thanks a lot for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few fixes for when using Babel as transpiler.
Babel andbrowserslist: falseRemove all Babel transformation plugins when usingbrowserslist: falseas documentedFixes #189@babel/plugin-syntax-dynamic-importresolutionResolving
@babel/plugin-syntax-dynamic-importdirectly is unsound since it is neither a dependency nor a peer dependency. pnpm is supposed to forbid this but don't know why it didn't. Resolve it from@babel/present-envFixes #185
@babel/*peers@babel/*packages didn't exist until Babel 7. Remove extraneous>=6.xfrom peer version ranges.