Do not count -1 as an overused expression

CHANGELOG.md

@@ -21,9 +21,16 @@ Semantic versioning in our case means:
 
 ### Features
 
+- **Breaking**: drops `python3.6` support
 - Adds `__init_subclass__` in the beginning of accepted methods
   order as per WPS338 #2411
 
+### Bugfixes
+
+- Fixes `WPS226` false positives on `|` use in `SomeType | AnotherType`
+  type hints syntax
+- Now `-1` is not reported to be an overused expression
+
 ### Misc
 
 - Adds full violation codes to docs and `BaseViolation.full_code` #2409
@@ -32,10 +39,6 @@ Semantic versioning in our case means:
 - Domain name was changed from `wemake-python-stylegui.de`
   to `wemake-python-styleguide.rtfd.io`
 
-### Bugfixes
-
-- Fixes `WPS226` false positives on `|` use in `SomeType | AnotherType` type hints syntax
-
 
 ## 0.16.1
 

tests/test_visitors/test_ast/test_complexity/test_overuses/test_overused_expressions.py

@@ -134,8 +134,8 @@ def method2(self, arg2: "List[int]") -> 'type.Any':
     '{a for a in other}',
 
     # Unary nodes:
-    '-1',  # unary minus operator is raising when used with literal
     '+some',  # unary plus always raises
+    '~other',
 
     # Special cases for self:
     'self.method([star])',  # `[star]` is raising
@@ -169,6 +169,8 @@ def method2(self, arg2: "List[int]") -> 'type.Any':
     'some.prop',
     # unary operator
     '-value',
+    '-value.attr',
+    '-1',
 )
 
 

wemake_python_styleguide/logic/complexity/overuses.py

@@ -102,12 +102,12 @@ def is_unary_minus(node: ast.AST) -> bool:
     We use this predicate to allow values
     like ``-some_value`` to be overused.
 
-    Although negative constants like ``-1``
+    Although negative constants like ``-5``
     should raise violation to force naming them.
     """
-    if isinstance(node, ast.UnaryOp):
-        return (
-            isinstance(node.op, ast.USub) and
-            not isinstance(node.operand, (Constant, ast.Num))
-        )
+    if isinstance(node, ast.UnaryOp) and isinstance(node.op, ast.USub):
+        # We allow variables, attributes, subscripts, and `-1`
+        if isinstance(node.operand, (Constant, ast.Num)):
+            return node.operand.n == 1
+        return True
     return False