Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not check | in type hints in WPS226 #2495

Merged
merged 3 commits into from Sep 23, 2022
Merged

Do not check | in type hints in WPS226 #2495

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a11982a
Do not check | in type hints in WPS226
dolfinus Sep 16, 2022
5252859
Update wemake_python_styleguide/visitors/ast/complexity/overuses.py
sobolevn Sep 18, 2022
8b43691
Update test_overused_string.py
dolfinus Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Expand Up @@ -32,6 +32,10 @@ Semantic versioning in our case means:
- Domain name was changed from `wemake-python-stylegui.de`
to `wemake-python-styleguide.rtfd.io`

### Bugfixes

- Fixes `WPS226` false positives on `|` use in `SomeType | AnotherType` type hints syntax


## 0.16.1

Expand Down
3 changes: 3 additions & 0 deletions tests/test_visitors/test_ast/test_complexity/test_overuses/test_overused_string.py
View file
Open in desktop
Expand Up @@ -177,6 +177,8 @@ def test_string_overuse(
'"GenericType[int, str]"',
'"int"',
'List["int"]',
'list[int]',
'int | None',
])
def test_string_type_annotations(
assert_errors,
Expand All @@ -202,6 +204,7 @@ def test_string_type_annotations(
'""',
'","',
'"."',
'"|"',
])
@pytest.mark.parametrize('prefix', [
'b',
Expand Down
2 changes: 2 additions & 0 deletions wemake_python_styleguide/visitors/ast/complexity/overuses.py
View file
Open in desktop
Expand Up @@ -48,13 +48,15 @@ class StringOveruseVisitor(base.BaseNodeVisitor):
'\n',
'\r\n',
'\t',
'|',
b' ',
b'.',
b',',
b'',
b'\n',
b'\r\n',
b'\t',
b'|',
dolfinus marked this conversation as resolved.
Show resolved Hide resolved
sobolevn marked this conversation as resolved.
Show resolved Hide resolved
))

def __init__(self, *args, **kwargs) -> None:
Expand Down