Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use immutable ref in pre-commit docs #230

Merged
merged 1 commit into from Apr 27, 2020
Merged

Use immutable ref in pre-commit docs #230

merged 1 commit into from Apr 27, 2020

Conversation

hukkin
Copy link
Contributor

@hukkin hukkin commented Apr 27, 2020

Use immutable ref instead of a branch name in pre-commit usage instructions.

Here's the pre-commit docs and rationale on this: https://pre-commit.com/#using-the-latest-version-for-a-repository

This PR uses one of the two documentation style suggestions by the pre-commit author psf/black#420 (comment)

Note that a version that includes the .pre-commit-hooks.yml file needs to be tagged before this works. I made the documented example version 0.2.0 but perhaps it should be 0.1.6? Which one is expected to be released next?

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #230 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #230   +/-   ##
=======================================
  Coverage   97.59%   97.59%           
=======================================
  Files          22       22           
  Lines         457      457           
  Branches       64       64           
=======================================
  Hits          446      446           
  Misses          8        8           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b45b9d3...d387386. Read the comment docs.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Very good practice.

README.md Show resolved Hide resolved
@sobolevn sobolevn merged commit 41aed86 into wemake-services:master Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants