Skip to content

Commit

Permalink
Remove never-used equality flags
Browse files Browse the repository at this point in the history
  • Loading branch information
muglug committed Dec 24, 2021
1 parent 4dfc7ce commit 18c790e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 9 deletions.
1 change: 0 additions & 1 deletion src/Psalm/Internal/Type/NegatedAssertionReconciler.php
Expand Up @@ -208,7 +208,6 @@ public static function reconcile(
$suppressed_issues,
$failed_reconciliation,
$is_equality,
$is_strict_equality,
$inside_loop
);

Expand Down
9 changes: 1 addition & 8 deletions src/Psalm/Internal/Type/SimpleNegatedAssertionReconciler.php
Expand Up @@ -65,7 +65,6 @@ public static function reconcile(
array $suppressed_issues = [],
int &$failed_reconciliation = Reconciler::RECONCILIATION_EMPTY,
bool $is_equality = false,
bool $is_strict_equality = false,
bool $inside_loop = false
): ?Union {
if ($assertion === 'object' && !$existing_var_type->hasMixed()) {
Expand Down Expand Up @@ -185,8 +184,6 @@ public static function reconcile(
$code_location,
$suppressed_issues,
$failed_reconciliation,
$is_equality,
$is_strict_equality,
false
);
}
Expand Down Expand Up @@ -575,8 +572,6 @@ private static function reconcileFalsyOrEmpty(
?CodeLocation $code_location,
array $suppressed_issues,
int &$failed_reconciliation,
bool $is_equality,
bool $is_strict_equality,
bool $recursive_check
): Union {
$old_var_type_string = $existing_var_type->getId();
Expand Down Expand Up @@ -732,7 +727,7 @@ private static function reconcileFalsyOrEmpty(

foreach ($existing_var_type->getAtomicTypes() as $type_key => $existing_var_atomic_type) {
if ($existing_var_atomic_type instanceof TTemplateParam) {
if (!$is_equality && !$existing_var_atomic_type->as->isMixed()) {
if (!$existing_var_atomic_type->as->isMixed()) {
$template_did_fail = 0;

$existing_var_atomic_type = clone $existing_var_atomic_type;
Expand All @@ -745,8 +740,6 @@ private static function reconcileFalsyOrEmpty(
$code_location,
$suppressed_issues,
$template_did_fail,
$is_equality,
$is_strict_equality,
true
);

Expand Down

0 comments on commit 18c790e

Please sign in to comment.