Skip to content
This repository has been archived by the owner on Jun 1, 2020. It is now read-only.

xmlToJson: xml2json -> Xml2js (fix #130) #143

Merged
merged 11 commits into from Aug 10, 2018
Merged

xmlToJson: xml2json -> Xml2js (fix #130) #143

merged 11 commits into from Aug 10, 2018

Conversation

huan
Copy link
Member

@huan huan commented Aug 9, 2018

xml2json requires native build, xml2js will not.

See: #130 wechaty/wechaty#1529

@huan huan changed the title xml2json -> Xml2js xmlToJson: xml2json -> Xml2js Aug 9, 2018
@huan huan requested a review from windmemory August 9, 2018 19:04
@huan huan changed the title xmlToJson: xml2json -> Xml2js xmlToJson: xml2json -> Xml2js (fix #130) Aug 9, 2018
@windmemory
Copy link
Member

Thanks for doing this refactor, this does help a lot on the build time.

@windmemory windmemory merged commit f1cb5e6 into master Aug 10, 2018
@lijiarui lijiarui deleted the xml2js branch September 4, 2018 11:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants