Add implementation for room-invite event #107
Conversation
I was using TypeError: Cannot read property 'request' of undefined
at RedirectableRequest._performRequest (/Users/yuangao/git/wechaty/wechaty-puppet-padchat/node_modules/follow-redirects/index.js:132:24)
at RedirectableRequest._processResponse (/Users/yuangao/git/wechaty/wechaty-puppet-padchat/node_modules/follow-redirects/index.js:222:10)
at ClientRequest.RedirectableRequest._onNativeResponse (/Users/yuangao/git/wechaty/wechaty-puppet-padchat/node_modules/follow-redirects/index.js:39:10)
at Object.onceWrapper (events.js:273:13)
at ClientRequest.emit (events.js:182:13)
at ClientRequest.EventEmitter.emit (domain.js:442:20)
at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:546:21)
at HTTPParser.parserOnHeadersComplete (_http_common.js:109:17)
at TLSSocket.socketOnData (_http_client.js:432:20)
at TLSSocket.emit (events.js:182:13)
at TLSSocket.EventEmitter.emit (domain.js:442:20)
at addChunk (_stream_readable.js:283:12)
at readableAddChunk (_stream_readable.js:264:11)
at TLSSocket.Readable.push (_stream_readable.js:219:10)
at TLSWrap.onread (net.js:635:20) Seems like error with Anyway, here is the workable prototype you asked, please let me know what do you think. |
Could you please deploy your workable prototype on a c9 IDE, so that we can run it? Because this PR can not workable without a runnable environment. If you have any trouble with your c9 account, we have a public c9 ide at https://ide.c9.io/zixia/wechaty-bug-reproducer and you can apply a write permission for that. But please be careful that it's public so everyone can read it. |
c9 IDE is closed for new signup, I am using @lijiarui 's account, and will have . I think it would be better to have a new tool in the future to replace the c9 since not everyone has c9 account. Here is the c9 workspace: https://ide.c9.io/lijiarui/room-invite-test |
Yes, I agree with you. Amazon sucks. |
Is there any documentation, or at least a note of how to run your code? |
@zixia Please let me know what do you think about this approach :) |
@zixia Do a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to support English language as well
Well, I think I should revoke this message. I will add English language as well. Is there any other comments besides the language? |
@zixia ping |
Will look into it for you this evening. |
Hi @zixia did you look into it? |
Please follow reply at wechaty/wechaty#1492 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your change is a BREAKING CHANGE and we have to bumper the version of wechaty-puppet-padchat from v0.8 to v0.9 to prevent breaking the old users.
package.json
Outdated
@@ -69,7 +69,7 @@ | |||
"tslint": "^5.10.0", | |||
"tslint-config-standard": "^7.1.0", | |||
"typescript": "^2.9.2", | |||
"wechaty": "^0.17.133" | |||
"wechaty": "^0.19.107" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to notify you that this is a BREAKING change and you should bump your MINOR version number when you changing the dependence to wechaty 0.17 to 0.19
Bumped |
Currently this is a prototype, not finished version.