Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use object shorthand for properties #220

Closed
wants to merge 1 commit into from

Conversation

LinusU
Copy link

@LinusU LinusU commented Apr 25, 2020

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[ ] Bug fix
[ ] New feature
[x] Other, please explain: lint update

What changes did you make? (Give an overview)

I started using object shorthand for properties, that is, I changed eslint: eslint to eslint.

Which issue (if any) does this pull request address?

standard/eslint-config-standard#166

Is there anything you'd like reviewers to focus on?

n/a


Compatibility: This syntax is supported in Node.js >=4, and it seems like Node.js 6.x is the minimum supported version as of c2771fa/9.0.0 ✅

@feross
Copy link
Member

feross commented May 12, 2020

@LinusU I just merged a refactor to ES6 so this PR doesn't apply cleanly any more. Can you resend it? Sorry for the trouble.

@LinusU
Copy link
Author

LinusU commented May 12, 2020

Neat! Latest master passes so no need to do anything more 👍

@LinusU LinusU closed this May 12, 2020
@LinusU LinusU deleted the object-shorthand branch May 12, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants