Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export CloseEvent, ErrorEvent, MessageEvent classes #2116

Closed
wants to merge 1 commit into from

Conversation

edolix
Copy link

@edolix edolix commented Feb 1, 2023

I don't know if you guys like the idea to make these classes public but i ended up implementing the CloseEvent class in one of my project (since i had to trigger it manually).

I thought it would be useful for others so that's the reason for the PR. If you think otherwise, feel free to close it!

Thanks for the great work on this package 馃挴

@lpinca
Copy link
Member

lpinca commented Feb 1, 2023

Thank you Edoardo but I think it is not a good idea to expose them because

  1. We are not strictly following the EventTarget specification (Use Node.js 15 native EventTarget object聽#1818).
  2. Those events should not be dispatched manually.

@edolix
Copy link
Author

edolix commented Feb 1, 2023

Sounds good @lpinca!
Thanks for the quick review - i'll close the PR!

@edolix edolix closed this Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants