Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Set permissions for GitHub actions #2051

Merged
merged 7 commits into from Jun 4, 2022
Merged

chore: Set permissions for GitHub actions #2051

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0a3b095
chore: Set permissions for GitHub actions
neilnaveen May 31, 2022
2502201
Update .github/workflows/ci.yml
lpinca Jun 4, 2022
5455046
Update .github/workflows/ci.yml
lpinca Jun 4, 2022
9a3d585
Update .github/workflows/ci.yml
lpinca Jun 4, 2022
7e74017
Update .github/workflows/ci.yml
lpinca Jun 4, 2022
a3953ef
Update .github/workflows/ci.yml
lpinca Jun 4, 2022
c90e723
Update .github/workflows/ci.yml
lpinca Jun 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Expand Up @@ -4,8 +4,14 @@ on:
- push
- pull_request

permissions:
contents: read
lpinca marked this conversation as resolved.
Show resolved Hide resolved

jobs:
test:
permissions:
checks: write # Needed for coverallsapp/github-action.
lpinca marked this conversation as resolved.
Show resolved Hide resolved
contents: read # for actions/checkout to fetch code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this inherited from the same permission defined at the root level? If so, can you please remove it?

lpinca marked this conversation as resolved.
Show resolved Hide resolved
runs-on: ${{ matrix.os }}
strategy:
matrix:
Expand Down Expand Up @@ -55,6 +61,8 @@ jobs:
github-token: ${{ secrets.GITHUB_TOKEN }}
parallel: true
coverage:
permissions:
checks: write
lpinca marked this conversation as resolved.
Show resolved Hide resolved
needs: test
runs-on: ubuntu-latest
steps:
Expand Down