Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attach error codes to all receiver errors #1901

Merged
merged 5 commits into from Jun 15, 2021
Merged

Attach error codes to all receiver errors #1901

merged 5 commits into from Jun 15, 2021

Commits on Jun 14, 2021

  1. Attach error codes to all receiver errors

    @pimterry
    pimterry committed Jun 14, 2021
    Copy the full SHA
    ff56ba6 View commit details
    Browse the repository at this point in the history

  2. Add docs for error codes

    @pimterry
    pimterry committed Jun 14, 2021
    Copy the full SHA
    12e9995 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2021

  1. Change 'invalid data payload' error code to 'unsupported message' 

    It's not technically invalid - the standard does not disallow the length
that's used - it's just that this specific endpoint won't accept it.

It's also not necessarily a single data payload - the total length might
come from a series of separate data frames comprising a single message.
    @pimterry
    pimterry committed Jun 15, 2021
    Copy the full SHA
    c818726 View commit details
    Browse the repository at this point in the history

  2. Add an separate WS_ERR_UNSUPPORTED_DATA_PAYLOAD_LENGTH error code

    @pimterry
    pimterry committed Jun 15, 2021
    Copy the full SHA
    11954cc View commit details
    Browse the repository at this point in the history

  3. Update error docs from review suggestions 

    Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
    @pimterry @lpinca
    pimterry and lpinca committed Jun 15, 2021
    Copy the full SHA
    2acd3cb View commit details
    Browse the repository at this point in the history