Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reset compressor/decompressor instead of re-initialize #1840

Merged
merged 2 commits into from Feb 2, 2021
Merged

reset compressor/decompressor instead of re-initialize #1840

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5ac59c
reset compressor/decompressor instead of re-initialize
cTn-dev Feb 2, 2021
db34dfb
nit: reorder
cTn-dev Feb 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 8 additions & 10 deletions lib/permessage-deflate.js
View file
Open in desktop
Expand Up @@ -377,13 +377,12 @@ class PerMessageDeflate {
);

if (fin && this.params[`${endpoint}_no_context_takeover`]) {
this._inflate.close();
this._inflate = null;
} else {
this._inflate[kTotalLength] = 0;
this._inflate[kBuffers] = [];
this._inflate.reset();
}

this._inflate[kTotalLength] = 0;
this._inflate[kBuffers] = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: can you move this before the if statement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done


callback(null, data);
});
}
Expand Down Expand Up @@ -449,13 +448,12 @@ class PerMessageDeflate {
this._deflate[kCallback] = null;

if (fin && this.params[`${endpoint}_no_context_takeover`]) {
this._deflate.close();
this._deflate = null;
} else {
this._deflate[kTotalLength] = 0;
this._deflate[kBuffers] = [];
this._deflate.reset();
}

this._deflate[kTotalLength] = 0;
this._deflate[kBuffers] = [];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and done


callback(null, data);
});
}
Expand Down