Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[minor] allow overriding default duplex stream options for createWebSocketStream #1647

Merged
merged 3 commits into from Oct 14, 2019
Merged

[minor] allow overriding default duplex stream options for createWebSocketStream #1647

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03291fa
[minor] allow overriding default duplex stream options for createWebS…
tadeuszwojcik Oct 11, 2019
0bf43b9
remove objectMode, writableObjectMode, readableObjectMode explicit op…
tadeuszwojcik Oct 11, 2019
aa3cc3e
Set the objectMode and writableObjectMode option to false
lpinca Oct 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/stream.js
View file
Open in desktop
Expand Up @@ -67,7 +67,6 @@ function createWebSocketStream(ws, options) {
autoDestroy: false,
emitClose: false,
objectMode: false,
lpinca marked this conversation as resolved.
Show resolved Hide resolved
readableObjectMode: false,
writableObjectMode: false
lpinca marked this conversation as resolved.
Show resolved Hide resolved
});

Expand Down