Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not waste time compressing when socket is closed #1464

Merged
merged 13 commits into from Nov 6, 2018
Merged

Do not waste time compressing when socket is closed #1464

merged 13 commits into from Nov 6, 2018

Commits on Oct 23, 2018

  1. Do not waste time trying to compress when socket is closed

    @Evertras
    Evertras committed Oct 23, 2018
    Copy the full SHA
    d160344 View commit details
    Browse the repository at this point in the history

  2. Remove errant extra new line

    @Evertras
    Evertras committed Oct 23, 2018
    Copy the full SHA
    b265319 View commit details
    Browse the repository at this point in the history

  3. Use once instead of on 

    Co-Authored-By: Evertras <bfullj@gmail.com>
    @lpinca @Evertras
    lpinca and Evertras committed Oct 23, 2018
    Copy the full SHA
    d75800e View commit details
    Browse the repository at this point in the history

  4. Update sender tests to use a simple mock socket

    Brandon Fulljames committed Oct 23, 2018
    Copy the full SHA
    c936a4c View commit details
    Browse the repository at this point in the history

  5. Check if callback is actually a function before calling it

    Brandon Fulljames committed Oct 23, 2018
    Copy the full SHA
    d780571 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2018

  1. Add tests to ensure erroring callbacks are in expected order with exp… 

    …ected state
    @Evertras
    Evertras committed Oct 25, 2018
    Copy the full SHA
    0444d5c View commit details
    Browse the repository at this point in the history

  2. Better test for CLOSING state on buffered compression attempts

    @Evertras
    Evertras committed Oct 25, 2018
    Copy the full SHA
    e2f4342 View commit details
    Browse the repository at this point in the history

  3. Remove errant console log

    @Evertras
    Evertras committed Oct 25, 2018
    Copy the full SHA
    edda00c View commit details
    Browse the repository at this point in the history

  4. Switch back to once instead of prepend, add comment for clarity instead

    @Evertras
    Evertras committed Oct 25, 2018
    Copy the full SHA
    88c5474 View commit details
    Browse the repository at this point in the history

  5. Fix error message for queued sender callbacks

    @Evertras
    Evertras committed Oct 25, 2018
    Copy the full SHA
    35105d2 View commit details
    Browse the repository at this point in the history

  6. Update lib/sender.js 

    Co-Authored-By: Evertras <bfullj@gmail.com>
    @lpinca @Evertras
    lpinca and Evertras committed Oct 25, 2018
    Copy the full SHA
    3303832 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2018

  1. Add the listener only when permessage-deflate is enabled

    @lpinca
    lpinca committed Oct 29, 2018
    Copy the full SHA
    20e9d85 View commit details
    Browse the repository at this point in the history

  2. Fix nits

    @lpinca
    lpinca committed Oct 29, 2018
    Copy the full SHA
    dc90638 View commit details
    Browse the repository at this point in the history