Exclude port 443 from host http header #248
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks to be common standard to strip the default http-based ports from the host header, when the port in mention is one of the two common default ports (e.g. port 80 and 443). This relates specifically to the initial negotiation.
E.g. for example: request/request#515 (comment)
I have been running into issues with this library directly, due to it commonly breaking upon handshakes with strictly-https endpoints.