[peer_connection] allow persistent certificates #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, make `pem` and `expires` fields private and add `RTCCertificate::new` method, which gives a way to construct a `RTCCertificate` using an already generated certificate (as opposed to generating a new one using `from_params` or `from_key_pair` methods). Fixes webrtc-rs#168
otherwise, it's not possible to reuse the same config across N peer connections.
Codecov Report
@@ Coverage Diff @@
## master #204 +/- ##
==========================================
+ Coverage 43.56% 43.63% +0.06%
==========================================
Files 68 68
Lines 9499 9514 +15
Branches 2739 2736 -3
==========================================
+ Hits 4138 4151 +13
- Misses 3371 3374 +3
+ Partials 1990 1989 -1
Continue to review full report at Codecov.
|
|
NOTE: this method does not exist in Go's Pion, but I believe adding it is reasonable. @rainliu any thoughts? |
|
Merged for now. We can always revert if needed since it's not breaking anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #168
This PR adds
RTCCertificate::from_existingmethod, which constructsRTCCertificatefrom an existing DTLS certificate. An existing certificate might be needed in cases like this where you need DTLS identity to be fixed for some period of time (whole duration of the certificate or some part of it).