close DTLS conn upon err #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
=======================================
Coverage 57.52% 57.52%
=======================================
Files 66 66
Lines 5784 5784
Branches 1797 1799 +2
=======================================
Hits 3327 3327
Misses 915 915
Partials 1542 1542
Continue to review full report at Codecov.
|
|
LGTM. could you rebase it? There are some conflicts need be resolved. |
It looks like we're not closing the connection upon ErrNoSRTPProtectionProfile / ErrNoRemoteCertificate errors. Plus we're logging the wrong error when fingerprint is bad.
melekes
force-pushed
the
anton/close-dtls-connection-upon-error
branch
from
173a230
to
c050d65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like we're not closing the connection upon
ErrNoSRTPProtectionProfile / ErrNoRemoteCertificate errors.
Plus we're logging the wrong error when fingerprint is bad.