always start sctp #170
Merged
always start sctp #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where if you set `disable_certificate_fingerprint_verification` to true via `SettingEngine`, even though DTLS handshake is completed, SCTP does not start. As you can see, this was due to the code returning `Ok(())` without changing the state and starting the sctp.
|
Good catch! |
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
=======================================
Coverage 57.52% 57.52%
=======================================
Files 66 66
Lines 5784 5784
Branches 1799 1797 -2
=======================================
Hits 3327 3327
Misses 915 915
Partials 1542 1542
Continue to review full report at Codecov.
|
melekes
deleted the
anton/start-sctp-when-fingerprint-verification-disabled
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where if you set
disable_certificate_fingerprint_verificationto true viaSettingEngine, even though DTLS handshake is completed, SCTP does notstart. As you can see, this was due to the code returning
Ok(())without changing the state and starting the sctp.