Add support for Laravel 6 #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed PHP 7.1 support in Travis and Scrutinizer Added Laravel 6 tests Add version constraint of Ocramius to <1.5 due to the PHP 7.3 requirement Remove PHPUnit 6 from version constraint Removed tests needing PHPUnit 6
|
I'm sorry for taking so long to reply. I doubt it is needed to remove support for Laravel 5.5 in order to add support for Laravel 6. I will give this package some TLC in the days to come. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Laravel 6 while maintaining support for Laravel 5.6 (probably 5.5 too, but that test was removed) and over.
Changes:
RuntimeExceptionassertContainsandassertNotContainstoassertStringContainsStringandassertStringNotContainsStringas per deprecation of the former methods in PHPUnit 8The PHP version increase is done for 2 reasons:
Perhaps doing a major bump is a good idea.