Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Jest to 24.3.0 #9545

Closed
wants to merge 26 commits into from
Closed

Upgrade Jest to 24.3.0 #9545

wants to merge 26 commits into from

Conversation

montogeek
Copy link
Member

@montogeek montogeek commented Aug 6, 2019

What kind of change does this PR introduce?

dependencies

Did you add tests for your changes?

existing tests

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

Nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@montogeek
Copy link
Member Author

montogeek commented Aug 7, 2019

Not sure why this fails:

  • It is not a memory issue, there is never an exception a "JavaScript heap out of memory" error.
  • forceExit is definitely necessary, but it feels like a hack :/

It seems the problem is not Jest but Yarn or something in between, in this commit Jest reports back that it is done, but the "(emoji) Done in X.XXs" message from Yarn is not shown.

@montogeek
Copy link
Member Author

Last changed work, so it is related when running a test (basic feature).

@webpack-bot
Copy link
Contributor

@montogeek The most important CI builds failed. This way your PR can't be merged.

Please take a look at the CI results from travis (error) and appveyor (failure) and fix these issues.

@montogeek
Copy link
Member Author

Will try installing watchman on Ubuntu 16.04

@sokra
Copy link
Member

sokra commented Aug 9, 2019

Maybe try to figure out which jest version introduced this problem

@niieani
Copy link
Contributor

niieani commented Sep 7, 2019

Could it be the V8 bug I encountered (never terminating process + memory growth)? nodejs/node#29001
I've included a workaround in jest 24.9.0 for that bug. Also, most recent node 12 also fixes the problem.

@sokra
Copy link
Member

sokra commented Sep 10, 2019

It indeed works with the latest jest version.

Thanks for your investment @montogeek

@sokra sokra closed this Sep 10, 2019
@montogeek
Copy link
Member Author

Wow, never thought that possibility! TIL :)

@montogeek montogeek deleted the ci/debug-jest branch September 10, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants