Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issues 9485 #9502

Closed
wants to merge 1 commit into from
Closed

fix issues 9485 #9502

wants to merge 1 commit into from

Conversation

EricAdonis
Copy link

Fixes #9485

What kind of change does this PR introduce?
Bug fix

Did you add tests for your changes?
N/A

Does this PR introduce a breaking change?
N/A

What needs to be documented once your changes are merged?
N/A

@jsf-clabot
Copy link

jsf-clabot commented Jul 31, 2019 •
edited

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

sokra
sokra requested changes Jul 31, 2019
View reviewed changes
Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test case

@sokra
Copy link
Member

sokra commented Jul 31, 2019

see also #9492

@EricAdonis EricAdonis closed this Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sokra sokra sokra requested changes

Assignees
No one assigned
Labels
PR: CI-ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

After change file .js (import (css, less, scss)), webpack result is error.
4 participants
@EricAdonis @jsf-clabot @webpack-bot @sokra