Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick terser to webpack 4 #8392

Merged
merged 3 commits into from Nov 19, 2018
Merged

Cherry-pick terser to webpack 4 #8392

merged 3 commits into from Nov 19, 2018

Commits on Nov 18, 2018

  1. Switch from uglifyjs-webpack-plugin to terser-webpack-plugin

    Some history:
    * `uglifyjs-webpack-plugin` < v1.0 used the minifier `uglify-js`
    * however `uglify-js` does not support ES6, which resulted in a fork
      called `uglify-es` that was developed in the `uglify-js` repository,
      but under the `harmony` branch
    * `uglifyjs-webpack-plugin` v1.x switched to `uglify-es` for ES6 support
    * however `uglify-es` stopped being maintained:
      mishoo/UglifyJS#3156 (comment)
    * which led to a fork called `terser` that has incorporated all of
      the unmerged PRs and will be where all new development occurs:
      https://github.com/fabiosantoscode/terser
    * `terser-webpack-plugin` was created, which is the `terser` equivalent
      of `uglifyjs-webpack-plugin`:
      https://github.com/webpack-contrib/terser-webpack-plugin
    * `uglifyjs-webpack-plugin` v2.x will be switching back to `uglify-js`,
      so any project that needs to support ES6 now needs to switch to
      `terser-webpack-plugin`.
    
    Fixes #7923.
    edmorley authored and vkrol committed Nov 18, 2018
    Copy the full SHA
    311a728 View commit details
    Browse the repository at this point in the history
  2. Rename test directories too

    edmorley authored and vkrol committed Nov 18, 2018
    Copy the full SHA
    b39abf4 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    a818def View commit details
    Browse the repository at this point in the history