Hashed chunk ids #8374
Closed
Hashed chunk ids #8374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
smelukov
force-pushed
the
hashed-chunks-id
branch
from
9f6a56f
to
4c0aec5
Compare
smelukov
force-pushed
the
hashed-chunks-id
branch
from
4c0aec5
to
499a321
Compare
|
I'll fix CI soon |
recreate id cache on each compilation
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
Any comments here? |
|
Looks good, but I want to add deterministic chunk ids too in this PR. Just didn't find the time yet. |
|
@sokra I’ll try to do it by my self |
|
fixed by other PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Added
chunkIds: "hashed"and enabled it for prod-mode for better long-term-cachingDid you add tests for your changes?
yes
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
about
chunkIds: "hashed"closes #8355