Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for #8293 #8337

Merged
merged 1 commit into from Nov 5, 2018
Merged

test for #8293 #8337

merged 1 commit into from Nov 5, 2018

Conversation

FranckFreiburger
Copy link
Contributor

@FranckFreiburger FranckFreiburger commented Nov 5, 2018

What kind of change does this PR introduce?
this highlights issue #8293

Did you add tests for your changes?

Does this PR introduce a breaking change?
no

What needs to be documented once your changes are merged?
nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@webpack-bot
Copy link
Contributor

The basic integration tests failed.

@FranckFreiburger Please review the following output log for errors:

 FAIL  test/ConfigTestCases.test.js (23.049s)
  ● ConfigTestCases › plugins › define-plugin › exported tests › should expand properly

    expect(function).not.toThrowError(type)

    Expected the function not to throw an error of type:
      "ReferenceError"
    Instead, it threw:
      ReferenceError: A_DOT_J is not defined
          239 | 	var tmp = '';
          240 | 	expect(function() {
        > 241 | 		__webpack_require__(2)('./' + A_DOT_J + tmp + 's');
              | 		                              ^
          242 | 	}).not.toThrowError(ReferenceError, "A_DOT_J is not defined");
          243 | });
          244 | 
    
          at test/js/config/plugins/define-plugin/bundle0.js:241:33
          at Object.<anonymous> (node_modules/expect/build/to_throw_matchers.js:51:9)
          at Object.throwingMatcher [as toThrowError] (node_modules/expect/build/index.js:320:33)
          at test/js/config/plugins/define-plugin/bundle0.js:242:9
          at Object.<anonymous> (test/helpers/createLazyTestEnv.js:12:13)

      240 | 	expect(function() {
      241 | 		__webpack_require__(2)('./' + A_DOT_J + tmp + 's');
    > 242 | 	}).not.toThrowError(ReferenceError, "A_DOT_J is not defined");
          | 	       ^
      243 | });
      244 | 
      245 | 

      at test/js/config/plugins/define-plugin/bundle0.js:242:9
      at Object.<anonymous> (test/helpers/createLazyTestEnv.js:12:13)
Test Suites: 1 failed, 2 passed, 3 total
Tests:       1 failed, 8 skipped, 1801 passed, 1810 total
Snapshots:   87 passed, 87 total
Time:        30.399s

See complete report here.

sokra added a commit that referenced this pull request Nov 5, 2018
walk inner expressions in wrapped context
add tracking of inner expressions in wrapped BasicEvaluatedExpression
fixes #8293
closes ##8337
@sokra sokra merged commit dcd0d59 into webpack:master Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants