Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add module argument to DefinePlugin.runtimeValue functions #8306

Merged
merged 5 commits into from Oct 31, 2018
Merged

add module argument to DefinePlugin.runtimeValue functions #8306

merged 5 commits into from Oct 31, 2018

Commits on Oct 30, 2018

  1. add module argument to DefinePlugin.runtimeValue functions 

    PR webpack#6793 added the ability for DefinePlugin to use function that return values.
This PR just add the ability to these functions to access the module being parsed (see webpack#8301).
eg.
```
  webpack.DefinePlugin.runtimeValue(module => module.resource ....)
```
    @FranckFreiburger
    FranckFreiburger committed Oct 30, 2018
    Copy the full SHA
    2b0025a View commit details
    Browse the repository at this point in the history

  2. - add a test for PR#8306

    @FranckFreiburger
    FranckFreiburger committed Oct 30, 2018
    Copy the full SHA
    979320e View commit details
    Browse the repository at this point in the history

  3. run eslint --fix

    @FranckFreiburger
    FranckFreiburger committed Oct 30, 2018
    Copy the full SHA
    a093cfa View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2018

  1. pass { module } instead of module 

    Co-Authored-By: FranckFreiburger <FranckFreiburger@users.noreply.github.com>
    @sokra @FranckFreiburger
    sokra and FranckFreiburger committed Oct 31, 2018
    Copy the full SHA
    7dc8e51 View commit details
    Browse the repository at this point in the history

  2. - update/enhance the test

    @FranckFreiburger
    FranckFreiburger committed Oct 31, 2018
    Copy the full SHA
    a640cd0 View commit details
    Browse the repository at this point in the history