Use Priority queue in chunk graph algorithm #8238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For maintainers only:
|
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ooflorent
requested changes
Oct 19, 2018
| this.heap = []; | ||
| /** @type {function(T):number}*/ | ||
| this.priorityFn = priorityFn; | ||
| for (let item of items) { |
There was a problem hiding this comment.
Since items is optional, you must use an if to guard the iteration
| } | ||
| const poppedValue = this.heap.pop(); | ||
| this._siftDown(); | ||
| return poppedValue.item; |
There was a problem hiding this comment.
Calling dequeue on an empty PriorityQueue would result in a TypeError. It would be better to change this line to:
Suggested change
| return poppedValue.item; | |
| return poppedValue ? poppedValue.item : undefined; |
webpack-bot
added
PR: reviewed-changes-requested
PR: conflict
and removed
PR: unreviewed
PR: CI-ok
labels
|
No longer needed because of #8242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
algorithmic performance improvement
Did you add tests for your changes?
existing tests
Does this PR introduce a breaking change?
no
What needs to be documented once your changes are merged?
nothing