Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sourcemap support for .mjs output files #7947

Merged
merged 3 commits into from Sep 15, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/SourceMapDevToolPlugin.js
Expand Up @@ -84,7 +84,7 @@ class SourceMapDevToolPlugin {
const fallbackModuleFilenameTemplate = this.fallbackModuleFilenameTemplate;
const requestShortener = compiler.requestShortener;
const options = this.options;
options.test = options.test || /\.(js|css)($|\?)/i;
options.test = options.test || /\.(m?js|css)($|\?)/i;

const matchObject = ModuleFilenameHelpers.matchObject.bind(
undefined,
Expand Down
5 changes: 3 additions & 2 deletions test/ConfigTestCases.test.js
Expand Up @@ -85,12 +85,13 @@ describe("ConfigTestCases", () => {
});
let testConfig = {
findBundle: function(i, options) {
const ext = path.extname(options.output.filename);
if (
fs.existsSync(
path.join(options.output.path, "bundle" + i + ".js")
path.join(options.output.path, "bundle" + i + ext)
)
) {
return "./bundle" + i + ".js";
return "./bundle" + i + ext;
}
},
timeout: 30000
Expand Down
@@ -0,0 +1,6 @@
it("creates source maps for .css output files by default", function() {
var fs = require("fs");
var source = fs.readFileSync(__filename, "utf-8");
var match = /sourceMappingURL\s*=\s*(.*)\*\//.exec(source);
expect(match[1]).toBe("bundle0.css.map");
});
@@ -0,0 +1,3 @@
var foo = {};

module.exports = foo;
@@ -0,0 +1,11 @@
module.exports = {
mode: "development",
output: {
filename: "bundle0.css"
},
node: {
__dirname: false,
__filename: false
},
devtool: "source-map"
};
@@ -0,0 +1,6 @@
it("creates source maps for .js output files by default", function() {
var fs = require("fs");
var source = fs.readFileSync(__filename, "utf-8");
var match = /sourceMappingURL\s*=\s*(.*)/.exec(source);
expect(match[1]).toBe("bundle0.js.map");
});
@@ -0,0 +1,3 @@
var foo = {};

module.exports = foo;
@@ -0,0 +1,11 @@
module.exports = {
mode: "development",
output: {
filename: "bundle0.js"
},
node: {
__dirname: false,
__filename: false
},
devtool: "source-map"
};
@@ -0,0 +1,6 @@
it("creates source maps for .mjs output files by default", function() {
var fs = require("fs");
var source = fs.readFileSync(__filename, "utf-8");
var match = /sourceMappingURL\s*=\s*(.*)/.exec(source);
expect(match[1]).toBe("bundle0.mjs.map");
});
@@ -0,0 +1,3 @@
var foo = {};

module.exports = foo;
@@ -0,0 +1,11 @@
module.exports = {
mode: "development",
output: {
filename: "bundle0.mjs"
},
node: {
__dirname: false,
__filename: false
},
devtool: "source-map"
};