Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "noop" changes in watch tests #5034

Closed

Conversation

yuriyostapenko
Copy link
Contributor

What kind of change does this PR introduce?
Adds watch test for "noop" change and support for skipping steps in watch tests

Did you add tests for your changes?
It is only tests

If relevant, link to documentation update:

Summary
Allows to skip test steps that are not supposed to trigger compilation changes

Does this PR introduce a breaking change?
No

Other information
Extracted from #3806

Allows to skip test steps that are not supposed to trigger compilation changes
@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change, broken test cases can be "skipped" if some change incorrectly doesn't trigger a rebuild. This can hide failures.

Make sure that skipping is opt-in. Maybe with a file .skip in the directory.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This need to be documented (issue in webpack/webpack.js.org will be filed when merged)

@sokra sokra closed this Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants