Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asset cache with "extract-text-webpack-plugin" #3806

Closed
wants to merge 5 commits into from

Commits on Jan 6, 2017

  1. Fix "extract-text-webpack-plugin" watch mode caching

    Add two tests asserting watch cache behavior (with and without the plugin).
    The lack of extra asset caching causes webpack to emit css files on every change (and report build taking place with noop JS changes).
    
    Add support for skipping watch test steps when no build is expected.
    Yuriy Ostapenko committed Jan 6, 2017
    Configuration menu
    Copy the full SHA
    090b638 View commit details
    Browse the repository at this point in the history
  2. Remove child asset hashes from compilation hash compilation

    Now that "extract-text-webpack-plugin" correctly adds asset hashes to compilation hash, this can be removed.
    
    I'm actually not sure whether it makes sense to keep it (not aware of any other plugins affected by this),
    But I'd remove it at least for now, because of how extract-text-webpack-plugin works today.
    Child compilation is only added if css changes, which breaks test case watchCases/plugins/extract-text-plugin step 3 (no-op JS change) on Windows and Linux.
    It works on macOS though, but only as a result of another bug: watchpack reports all files as changed on that platform.
    Yuriy Ostapenko committed Jan 6, 2017
    Configuration menu
    Copy the full SHA
    e2d8478 View commit details
    Browse the repository at this point in the history
  3. Update affected test expectation

    Yuriy Ostapenko committed Jan 6, 2017
    Configuration menu
    Copy the full SHA
    3f8ea5e View commit details
    Browse the repository at this point in the history
  4. Fix lint error

    Excuse: beautify-lint does not match file patterns with forward slash on Windows
    Yuriy Ostapenko committed Jan 6, 2017
    Configuration menu
    Copy the full SHA
    d4964c7 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2017

  1. Configuration menu
    Copy the full SHA
    fe8fb70 View commit details
    Browse the repository at this point in the history