Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for multiple inlined modules #18355

Merged
merged 1 commit into from May 7, 2024

Conversation

fi3ework
Copy link
Contributor

What kind of change does this PR introduce?

Currently, there's no test case covering the following condition, if we comment this condition, no test will fail.

: inlinedModules.size > 1
? // TODO check globals and top-level declarations of other entries and chunk modules

Did you add tests for your changes?

Adding a multiple inline modules case to cover the condition. Multiple entry file have declared same identifiers, so does non-inline modules to make sure it won't break in a more complex scenario.

Does this PR introduce a breaking change?

No.

What needs to be documented once your changes are merged?

No.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@alexander-akait alexander-akait merged commit a679033 into webpack:main May 7, 2024
54 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants