Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support "..." in resolve importsFields #18351

Merged

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Apr 25, 2024

What kind of change does this PR introduce?

feat or fix, before using importsFields: ["custom", "..."] won't work, since there isn't a default value for importsFields

Did you add tests for your changes?

added

Does this PR introduce a breaking change?

No

What needs to be documented once your changes are merged?

mention supports "..." in resolve importsFields (if needed)

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@ahabhgk ahabhgk force-pushed the feat-supports-dot-in-imports-fields branch from 6ad1c7d to 0de9b1d Compare April 25, 2024 07:54
@alexander-akait alexander-akait merged commit 7ba3705 into webpack:main May 7, 2024
54 of 56 checks passed
@ahabhgk ahabhgk deleted the feat-supports-dot-in-imports-fields branch May 7, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants