Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should count in module scope variables #18349

Merged
merged 1 commit into from May 7, 2024

Conversation

fi3ework
Copy link
Contributor

What kind of change does this PR introduce?

Fix some issues introduced in #18348.

  • include existing module identifiers to used names to avoid conflict after renaming symbols.
  • refactor some logic to make it cleaner.
  • correct the typo in the test case path.

Did you add tests for your changes?

Yes, in test/configCases/output-module/inlined-module/index.js, adding a index_value identifier which value will be renamed to, this will break the runtime before the PR as we didn't count existing identifiers in.

Does this PR introduce a breaking change?

No.

What needs to be documented once your changes are merged?

No.

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@alexander-akait alexander-akait merged commit 3f5a5ab into webpack:main May 7, 2024
52 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants