Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run tests on node v19 #16813

Closed
wants to merge 2 commits into from
Closed

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Mar 12, 2023

What kind of change does this PR introduce?
CI (also need update deps).

Run tests on node 19 as well.

Did you add tests for your changes?
No need.

Does this PR introduce a breaking change?
No

What needs to be documented once your changes are merged?
Nothing

@webpack-bot
Copy link
Contributor

For maintainers only:

  • This needs to be documented (issue in webpack/webpack.js.org will be filed when merged)
  • This needs to be backported to webpack 4 (issue will be created when merged)

@snitin315
Copy link
Member Author

I believe we need to update jest.

@alexander-akait
Copy link
Member

Wierd:

Unable to find JEST_STATE_SYMBOL in Symbol(jest-native-promise), Symbol(jest-native-now), Symbol(jest-native-read-file), Symbol(jest-native-write-file), Symbol(jest-native-exists-file), Symbol($$jest-matchers-object), Symbol(graceful-fs.queue)

I believe we need to update jest.

Yeah, but we still need to run tests on Node.js v10, anyway we try to update jest and install old version of jest for v10

@TheLarkInn
Copy link
Member

@snitin315

This is the suspect code:

const STATE_SYM = Object.getOwnPropertySymbols(global).find(
Symbol("x").description
? s => s.description === "JEST_STATE_SYMBOL"
: s => s.toString() === "Symbol(JEST_STATE_SYMBOL)"
);
if (!STATE_SYM) {
throw new Error(
`Unable to find JEST_STATE_SYMBOL in ${Object.getOwnPropertySymbols(global)
.map(s => s.toString())
.join(", ")}`
);
}

It appears to break due to any Node version > 16

@alexander-akait
Copy link
Member

I will look at this

@alexander-akait
Copy link
Member

@SimenB Friendly ping, maybe you can give us some advices, I tried to find why it doesn't work on v18 and no luck, I found jest has require("jest-circus/build/state").getState(), but it looks like return no current state, because currentDescribeBlock.tests is empty. So what is the big different between jest v27 on Node v16 and Node v18? May it be a bug?

@snitin315 snitin315 deleted the ci/add-node-19 branch April 12, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants