-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run tests on node v19 #16813
ci: run tests on node v19 #16813
Conversation
For maintainers only:
|
I believe we need to update jest. |
Wierd:
Yeah, but we still need to run tests on Node.js v10, anyway we try to update jest and install old version of jest for v10 |
This is the suspect code: webpack/test/helpers/createLazyTestEnv.js Lines 1 to 12 in b7fc4d8
It appears to break due to any Node version > 16 |
I will look at this |
@SimenB Friendly ping, maybe you can give us some advices, I tried to find why it doesn't work on v18 and no luck, I found jest has |
What kind of change does this PR introduce?
CI (also need update deps).
Run tests on node 19 as well.
Did you add tests for your changes?
No need.
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Nothing