Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add i64 to the set of JS-compatible wasm types in syncWebAssembly mode #16339

Merged
merged 2 commits into from Nov 9, 2022
Merged

Add i64 to the set of JS-compatible wasm types in syncWebAssembly mode #16339

merged 2 commits into from Nov 9, 2022

Commits on Oct 6, 2022

  1. Add i64 to the set of JS-compatible wasm types in syncWebAssembly… 

    … mode

For quite a while now, it's been possible for WebAssembly `i64`s to be converted to/from JS bigints (as function parameters, results, etc.). However, `syncWebAssembly` mode currently rejects any modules that attempt to do so, because `i64` isn't in it's list of JS-compatible types. This fixes that by adding `i64` to that list.

There was an existing test that used `i64` as an example of a non-JS-compatible type; I replaced that with `v128`.
    @Liamolucko
    Liamolucko committed Oct 6, 2022
    Copy the full SHA
    a74f64e View commit details
    Browse the repository at this point in the history

  2. Use webassembly-feature properly

    @Liamolucko
    Liamolucko committed Oct 6, 2022
    Copy the full SHA
    cb9248c View commit details
    Browse the repository at this point in the history